Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Zephyr examples into Zephyr upstream #41

Open
glneo opened this issue May 15, 2024 · 1 comment
Open

Move Zephyr examples into Zephyr upstream #41

glneo opened this issue May 15, 2024 · 1 comment

Comments

@glneo
Copy link
Contributor

glneo commented May 15, 2024

The Zephyr project seems open to examples and already has some for OpenAMP[0].

Examples here as a downstream will have the normal issues downstream projects tend to have (maintenance of keeping things in sync means we have these demos locked to a specific Zephyr version. Upstream they would be migrated with changes in Zephyr for any given version).

We should move the two current Zephyr examples into upstream Zephyr and update the docs (examples/zephyr/README.md) to explain how to find and build those examples in the Zephyr tree instead.

[0] https://github.com/zephyrproject-rtos/zephyr/tree/main/samples/subsys/ipc

@arnopo
Copy link
Collaborator

arnopo commented May 16, 2024

The rpmsg_multi_services sample relies on two things that prevent it from being mergeable in its current state in Zephyr:

If we address these points, in my opinion, we will have a sample very close to what is already available at Zephyr openamp_rsc_table.

This would mean:

  • Remove Linux patch and capability to use the NS annoucement on Linux rpmsg endpoint creation.
  • removing the rpmsg_multi_services sample (and possibly improving the Zephyr openamp_rsc_table sample)
  • keeping the readme file explaining the demo using rpmsg-utils.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants