TODO: Extend lint rules for Pylint

[R1kaB3rN]

Related to #48 (comment)

For quality assurance and to prevent bugs such as ac9ddf2, more lint rules should be extended and applied to the Protonfix/gamefix modules.

[Root-Core]

If I don't misunderstand you, this is already the case with commit c956ac9, the , adds the files on the root level.

Well, we could just enforce it on all *.py files - without the "static" array.

[R1kaB3rN]

If I don't misunderstand you, this is already the case with commit c956ac9, the , adds the files on the root level.

Sorry, my description was sloppy/inaccurate there. Thanks for the correction.

Well, we could just enforce it on all *.py files - without the "static" array.

Yeah and probably define some files to exclude such as __init__.py for the gamefixes in pyproject.toml

[Root-Core]

No problem. I moved the linked comment here for better discussion. I also expanded it a bit.

---

We should enforce this via linter:

• function types
• single quotes
• format strings
• Docstrings for each function (C0116)
• Docstrings indentation on multiple lines
• no blank lines after function Docstrings
• two blank lines between functions
• a reasonable line length (?)

We want to:

• Check if there are unused functions
• Check that GDrive is actually working
• Split large modules like util.py into smaller ones
• Enforce linter on all *.py files
• Handle the complete linter configuration in the pyproject.toml file
• Remove #pylint: disable=C0103 from gamefixes
• Have as few pylint exceptions as possible

[R1kaB3rN]

I think enforcing rules for Docstrings will require additional tools than pylint. Personally, I'd like to just have one tool for the sake of simplicity.

In addition, there should probably as much tests as possible. In particular for critical files such as fix.py and util.py