Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detail and fix RegExp funnel matcher #909

Open
wernight opened this issue Feb 8, 2024 · 0 comments
Open

Detail and fix RegExp funnel matcher #909

wernight opened this issue Feb 8, 2024 · 0 comments
Labels
bug Bug in code confirmed and identified.

Comments

@wernight
Copy link

wernight commented Feb 8, 2024

OWA Version: 1.7.8

PHP Version: 8.2 FPM

Webserver: Nginx

Browser: N/A

Description

Funnels allow using RegExp however there is no proper escaping and the feature should be detailed in the WiKi.

Possible Solution

  • First the WiKi should explain that the RegExp matches partial strings (e.g. /foo matches bar/foo). It should also say that it's case-incensitive. More importantly it should explain if and when the steps may also match a RegExp.
  • Regarding the escaping, you can see:
    $pattern = sprintf('@%s@i', $step['url']);
    $check = preg_match($pattern, $page_uri );
    There it should escape the @ in the RegExp.
  • As a feature request, it'd be useful to have a place to put a URL and check which step(s) match it.
  • Another bug is the "Watch downstream" button in the funnel which actually does a URI match even when it should do a RegEx match. See
    $doc->getByColumn('uri', $this->getParam('pagePath'));
  • Lastly, from the code and a brief testing, I'm not convinced that the funnel works with multiple steps and RegExp: seem not to care about the match_type.
@wernight wernight added the bug Bug in code confirmed and identified. label Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug in code confirmed and identified.
Projects
None yet
Development

No branches or pull requests

1 participant