Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: configurable gas price #58

Open
yehjxraymond opened this issue Jun 8, 2020 · 5 comments
Open

feat: configurable gas price #58

yehjxraymond opened this issue Jun 8, 2020 · 5 comments

Comments

@yehjxraymond
Copy link
Contributor

Allow the user to specify gas price or have option for normal, fast or fastest when sending a transaction...

or the transaction will get stuck on a busy day like:

image

@Nebulis
Copy link
Contributor

Nebulis commented Jun 8, 2020

Should we find a way to cancel transaction first ? I guess it's ok on ropsten but on mainnet u likely dont want to send the "same" transaction twice

@yehjxraymond
Copy link
Contributor Author

You can't really cancel a transaction i think? It's probabilistic at best by sending a replacement tx...

@Nebulis
Copy link
Contributor

Nebulis commented Jun 8, 2020

No idea what you can do but basically you might not think about this issue until it happens:

  • you run a command
  • after a min you think that you should have specified higher gas price
  • too bad it's too late u already started and cant cancel ? or can u run again with higher price ?

just to say that you might not specify the gas until you have the problem. (I like the option though)

@gjj
Copy link

gjj commented Jun 8, 2020

I think the normal, fast and fastest option seems to be a Metamask thing. Not sure if it helps but maybe this is a potential solution?

From https://ethereum.stackexchange.com/a/76285:

To "speed up a transaction" there's only one possible option: to send a new transaction with higher gas price but with the same nonce. This way if nodes see both of the transactions they will most likely pick up the one with the higher gas price and once that is mined the other transaction becomes invalid (a tx with that nonce has already been mined) and is ignored & dropped.

Thought that this article explains speeding up transactions quite well: https://blog.blocknative.com/blog/speed-up-transactions

@Nebulis
Copy link
Contributor

Nebulis commented Jul 1, 2020

Done in #65 , do you want to close this @yehjxraymond ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants