Skip to content
This repository has been archived by the owner on Mar 3, 2022. It is now read-only.

Doors sounds only work one direction #127

Open
TelloViz opened this issue Nov 23, 2019 · 4 comments
Open

Doors sounds only work one direction #127

TelloViz opened this issue Nov 23, 2019 · 4 comments
Labels
enhancement When the issue is proposing an enhancement

Comments

@TelloViz
Copy link
Contributor

Doors activate sound upon entering a building but not upon leaving.

I'm new around here so let me know if I submitted this wrong :)

@milkyroute milkyroute added the enhancement When the issue is proposing an enhancement label Nov 23, 2019
@milkyroute
Copy link
Member

In fact, it's only something the game doesn't do because we haven't programmed it. This is quite minor yet, so I won't fix this soon, but I keep it because it has to be done.

@milkyroute milkyroute assigned milkyroute and unassigned milkyroute Nov 23, 2019
@TelloViz
Copy link
Contributor Author

So I found the door event code where it is given an entrance sound on creation. Would there simply need to be an exit sound? Or does entering a house count as a different map, therefore all doors in the house would also just have entrance sounds and no additional exit sound code would be needed ? Does this make sense?

@milkyroute
Copy link
Member

We've planned to do an more complex animation for entering and living houses. Right now, there's no animation at all, the event is not even counted as a door. What the event should do is to teleport the player on the opened door on the outdoor map and then making the character move forward by one tile while the door is closing behind. So, for this, a new event type would have to be created. As you submitted on the Discord server, splitting more the events would be interesting to do this, for the audio for example.

@TelloViz
Copy link
Contributor Author

I think this issue is contingent on #131 so I just want to reference it here.

@milkyroute milkyroute assigned TelloViz and unassigned TelloViz Nov 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement When the issue is proposing an enhancement
Projects
None yet
Development

No branches or pull requests

2 participants