Skip to content
This repository has been archived by the owner on Mar 3, 2022. It is now read-only.

Enhancement: Camera centered on player #101

Open
PyroFlareX opened this issue May 22, 2019 · 5 comments
Open

Enhancement: Camera centered on player #101

PyroFlareX opened this issue May 22, 2019 · 5 comments
Labels
enhancement When the issue is proposing an enhancement
Milestone

Comments

@PyroFlareX
Copy link

Always have the player character at the center of the screen if possible. Exceptions being when you deem it to be.

@PyroFlareX PyroFlareX changed the title Enhancement Enhancement: Camera centered on player May 22, 2019
@milkyroute milkyroute added enhancement When the issue is proposing an enhancement priority : 1/3 labels May 22, 2019
@milkyroute
Copy link
Member

milkyroute commented May 22, 2019

It has been the case some time ago. However, we changed for many reasons, one of them being that we had to create large maps with unaccessible places to hide black from the player. If you have some arguments to give, we will listen to them joyfully, but for now I don't think we will change the camera for now. Thank you anyway! I'm leaving this issue open for a while if you want to give some reasons or arguments.

@PyroFlareX
Copy link
Author

I agree with your above reasons, but for the areas you want to hide, just make it so the camera doesn't move into those areas. That way, it is the best of both.

@milkyroute
Copy link
Member

milkyroute commented May 24, 2019

Isn't it already the case? The camera doesn't move into black areas, because it stops at the edge of the map. Except for the indoor maps, but it's normal, it's already the case in Pokemon. Or I misunderstood what you meant?
Edit : It isn't, after all. We will think about it, but I don't think it's a bad idea.

@PyroFlareX
Copy link
Author

Like you said above, the camera doesn't center on the player. Instead the player has a weird space that can be described by testing. Maybe having the camera move with the player, but has collision detection at the edges, and tries to recenter on the player? That could work for implementation.

@milkyroute
Copy link
Member

milkyroute commented May 31, 2019

I will do a poll on the Discord server to know what people prefer, and then I will change it for the 0.17 if they want it.
Edit : The Discord server choose to change the camera.

@milkyroute milkyroute added this to To do in To do for the 0.16 via automation Jun 26, 2019
@milkyroute milkyroute modified the milestones: For the 0.16, For the 0.17 Jun 26, 2019
@milkyroute milkyroute removed this from To do in To do for the 0.16 Jun 26, 2019
@milkyroute milkyroute removed the read label Sep 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement When the issue is proposing an enhancement
Projects
None yet
Development

No branches or pull requests

3 participants