Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete most files from static/FinalOutputs/data #683

Closed
davidebbo opened this issue Nov 23, 2023 · 3 comments · Fixed by #837
Closed

Delete most files from static/FinalOutputs/data #683

davidebbo opened this issue Nov 23, 2023 · 3 comments · Fixed by #837

Comments

@davidebbo
Copy link
Contributor

This static/FinalOutputs/data folder has various ancient versions of the generated static files. Do they serve any purpose? I would think that anyone who wants to run the site should generate fresh files (using the tree-build steps).

And the folder should have a .gitignore.
@hyanwong
Copy link
Member

hyanwong commented Nov 23, 2023 •
edited

James wanted to have some permanent record of previous versions of the tree, for posterity and possibly reuse, so we decided to save them here.

@davidebbo
Copy link
Contributor Author

Fair enough.

@davidebbo
Copy link
Contributor Author

We can keep these files, but we can also add a .gitignore, so that new files used for testing don't get treated by git as an untracked change.

@davidebbo davidebbo reopened this Apr 25, 2024
davidebbo added a commit to davidebbo/OZtree that referenced this issue Apr 25, 2024
@davidebbo
Ignore new FinalOutputs/data files
53621a6 
But we can keep the current ones in git. Fixes OneZoom#683
@davidebbo davidebbo mentioned this issue Apr 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ignore new FinalOutputs/data files davidebbo/OZtree
2 participants
@davidebbo @hyanwong