Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treeviewer stalls if node_details API returns empty data #831

Open
hyanwong opened this issue Apr 24, 2024 · 2 comments
Open

Treeviewer stalls if node_details API returns empty data #831

hyanwong opened this issue Apr 24, 2024 · 2 comments

Comments

@hyanwong
Copy link
Member

See #827. If the API is returning no data for leaves, the JS console is filled with:

TypeError in OZentry, when evaluating e.length

Not only does this fill up the console logs, but it completely stalls the tree viewer. We should handle this more gracefully.

@lentinj
Copy link
Collaborator

lentinj commented Apr 24, 2024

Not just "no data for leaves", any exception will cause node_details to return {}.

  • The error is thrown away server-side
  • The client doesn't check for missing entries in the response and falls over
  • The client doesn't give up, it just keeps retrying

@hyanwong
Copy link
Member Author

Perhaps we should return blank entries for each node ID instead, so that at least we don't keep on retrying?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants