Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

myconf.take('paypal.save_to_tmp_file_dir') should be wrapped with exception handling #823

Open
lentinj opened this issue Apr 23, 2024 · 2 comments
Open

myconf.take('paypal.save_to_tmp_file_dir') should be wrapped with exception handling #823

lentinj opened this issue Apr 23, 2024 · 2 comments
Labels
background refactor Low-priority refactoring to do whilst touching code anyway bug

Comments

@lentinj
Copy link
Collaborator

lentinj commented Apr 23, 2024

If there's no paypal.save_to_tmp_file_dir then PP_process_post will fail currently. The myconf.take should be wrapped & provide a default.

A default in the example config will lessen the effect of this: db9bdff
@lentinj lentinj added bug background refactor Low-priority refactoring to do whilst touching code anyway labels Apr 23, 2024
@hyanwong
Copy link
Member

hyanwong commented May 4, 2024

Could we simply use myconf.get for this @lentinj ?

@lentinj
Copy link
Collaborator Author

lentinj commented May 7, 2024

If that works as we'd like now, don't see why not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
background refactor Low-priority refactoring to do whilst touching code anyway bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lentinj @hyanwong