Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove links from tours for museum displays #810

Open
hyanwong opened this issue Apr 17, 2024 · 2 comments
Open

Remove links from tours for museum displays #810

hyanwong opened this issue Apr 17, 2024 · 2 comments

Comments

@hyanwong
Copy link
Member

When a tour is viewed in "museum display" mode (e.g. https://beta.onezoom.org/life_MDtouch/), we should make sure that the user can't follow URL links (I don't know if this is possible for videos, however). For example, the first stop on the "Cats" tour has an image which links out to wikipedia This would allow museum display users to escape the OneZoom sandbox.

There is a system implemented in the layout modules for checking whether we are in a mode which allows links to be followed: we should tie in to that properly.

@lentinj
Copy link
Collaborator

lentinj commented Apr 18, 2024

AFAIK the only links we have are for image copyright purposes, which wouldn't be accessible if we just got rid of the link. We could disable these easily enough, but that's not ideal.

Showing the content, link-stripped in a pop-up as we do with wikipedia tabs would be the right thing to do, but I'm not sure how easy that would be off the top of my head.

I guess eventually we'll have a similar problem with "window_text" containing links, they could be stripped but it might make the resultant text read weird---"click here to visit the EoL website" with no link.

lentinj added a commit that referenced this issue Apr 23, 2024
The tours contain media copyright links we can't remove, and once
followed you're outside the onezoom sandbox.

We either need to pop-up-ize them like we do with wikipedia, or pull an
attribution line in javascript. Either is relatively fiddly.

Disable tours for now. NB: the tours tab is already disabled, so we
just have to hide the controls at the side.
lentinj added a commit that referenced this issue Apr 23, 2024
views/life_MD: Disable tours in museum display #810
@lentinj
Copy link
Collaborator

lentinj commented Apr 23, 2024

For now the tours mechanism is entirely hidden on a museum display, although with an appropriately crafted URL you could still activate a tour.

I think using javascript to extract a Credit Line for a wikimedia image, and ensuring we have a convention to extract credit lines out of our own pages, is the way forward.

If this is done, then we can add a mechanism to strip the links from museum display tour images.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants