Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Back and next arrows on sponsor_node page lead to unexpected behaviour #794

Open
hyanwong opened this issue Apr 15, 2024 · 7 comments
Open

Comments

@hyanwong
Copy link
Member

hyanwong commented Apr 15, 2024

Clicking the arrow ringed in red here:

Screenshot 2024-04-15 at 18 19 08

Should normally advance the in-page row to some new species. Now, instead, it leads to this page:

Screenshot 2024-04-15 at 18 20 46
@hyanwong
Copy link
Member Author

hyanwong commented Apr 15, 2024

I assume we have lost some sort of styling here? This is new behaviour, so I don't know what has changed.

Having said which, it seems to be doing this on production too. Damn.

@hyanwong hyanwong changed the title Back and next arrows on sponsor_node page lead to unsettled behaviour Back and next arrows on sponsor_node page lead to unexpected behaviour Apr 15, 2024
@lentinj
Copy link
Collaborator

lentinj commented Apr 15, 2024

I'd assume the link wasn't intended to be followed, instead the carousel contents should have been replaced.

Any javascript errors in the console?

@hyanwong
Copy link
Member Author

For triage, this is the system we are using:

http://web2py.com/books/default/chapter/29/12/components-and-plugins#Trapped-Ajax-links-and-the-A-Helper

See e.g.

<li>{{=A(XML('&gt;'),_href=URL(vars=vars),cid=request.cid)}}<li>

@hyanwong
Copy link
Member Author

I'd assume the link wasn't intended to be followed, instead the carousel contents should have been replaced.

Any javascript errors in the console?

Yep:
Untitled

I'm thinking we might need to update the stuff in static/js

@hyanwong
Copy link
Member Author

hyanwong commented Apr 15, 2024

OK, I've tracked this down. It's because of this line:

<!-- include 'web2py_ajax.html' could be done here, but it performs more than we want so we disect it and keep only the bits we really need -->

There is some functionality in web2py_ajax.html that we do need and we are not importing.

Is it just the calendar stuff we are discarding? If so, maybe we should simply comment that out from the web2py_ajax.html file and then include it after all, rather than hand-coding? What do you think @lentinj ?

@hyanwong
Copy link
Member Author

Also, there's no harm in updating the various web2py-specific things in static/js, I suppose?

@hyanwong
Copy link
Member Author

Fixed by #806

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants