Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add controller support for deleting tours and associated data #767

Open
davidebbo opened this issue Mar 18, 2024 · 1 comment
Open

Add controller support for deleting tours and associated data #767

davidebbo opened this issue Mar 18, 2024 · 1 comment

Comments

@davidebbo
Copy link
Contributor

It would probably be via:

DELETE http://localhost:8000/tour/data.json/[name]

Also, I'm not sure if there is currently a plain LIST action. The current list() in tour.py seems to require passing a list of tour IDs to get details back, but doesn't list the tours if you don't know their IDs.

This is probably low priority for now, as it's easy enough to get by directly through the DB.

@lentinj
Copy link
Collaborator

lentinj commented Mar 18, 2024

Also, I'm not sure if there is currently a plain LIST action

There isn't. The client already knows what tours are associated to which nodes / leaves, and is in a better place to decide how exciting a tour is (if it's on-screen, if it's something a user has seen before). So the /tour/list endpoint just does what the client tells it to. As things stand today there's not much reason to add one.

Also, arguably the PUT/DELETE endpoint should be in /API/tour. But I think the idea with the API controller is for things we're publicly offering, rather than just anything that speaks JSON. I'm not convinced we should muddy the waters there with something that likely isn't useful for others, especially as we may well re-think this if/when user-generated tours come about.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants