Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seems like you included .git/ folder inside the npm package #762

Closed
mtt87 opened this issue May 16, 2019 · 3 comments
Closed

Seems like you included .git/ folder inside the npm package #762

mtt87 opened this issue May 16, 2019 · 3 comments

Comments

@mtt87
Copy link

mtt87 commented May 16, 2019

Description:
Seems like you included the .git folder with the package release.
This is problematic because it can throw errors like these when trying to install other packages

npm ERR! path /node_modules/react-native-onesignal
npm ERR! code EISGIT
npm ERR! git /node_modules/react-native-onesignal: Appears to be a git repo or submodule.
npm ERR! git     /react-native-onesignal
npm ERR! git Refusing to remove it. Update manually,
npm ERR! git or move it out of the way first.

Environment
Using "react-native-onesignal": "^3.2.13"

Steps to Reproduce Issue:
Install the package then try to install any other package, i.e.
npm i --save react-native-onesignal
npm i --save react-native-schemes-manager

Anything else:

It can be temporarily fixed by removing /node_modules/react-native-onesignal/.git but the git folder should not be inculded in the npm released package.

@thinklinux
Copy link

Yeap and npm install fails every time because of that. It's kind of annoying :)

@rgomezp
Copy link
Contributor

rgomezp commented May 20, 2019

Hello,
Thanks for bringing this up! We're so sorry and will try to get this fixed asap.

@rgomezp
Copy link
Contributor

rgomezp commented May 28, 2019

Hello everyone, this has been fixed.

@rgomezp rgomezp closed this as completed May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants