Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how to pass options to postNotification #367

Closed
leoskyrocker opened this issue Jan 18, 2018 · 2 comments
Closed

Document how to pass options to postNotification #367

leoskyrocker opened this issue Jan 18, 2018 · 2 comments

Comments

@leoskyrocker
Copy link

leoskyrocker commented Jan 18, 2018

I came across a few unresolved issues related to how to pass additional options to postNotification.
It is undocumented currently but actually implemented since v3.0.5 via #266.
It is now possible to call postNotification like this:

const otherParameters = {subtitle: 'subtitle', headings: {"en": "English Title"}}
OneSignal.postNotification(contents, data, playerId, otherParameters)

where otherParameters is anything options supported by create-notification endpoint.

Unresolved but relevant issues:
#262
#142
#253
#218

I'll try to see if I have time to submit a PR in the next few days.
For now, this can at least still serve as an information post for other people looking for the solution.

@leoskyrocker
Copy link
Author

leoskyrocker commented Jan 22, 2018

Closing as it got documented in 5b69508.

Thanks @Nightsd01!

@leoskyrocker
Copy link
Author

@avishayil you could probably close all the other issues too =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant