Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Onesignal TestFlight to reject project because of Bitcode #1518

Closed
2 of 3 tasks
Rommadon opened this issue May 26, 2023 · 3 comments
Closed
2 of 3 tasks

[Bug]: Onesignal TestFlight to reject project because of Bitcode #1518

Rommadon opened this issue May 26, 2023 · 3 comments

Comments

@Rommadon
Copy link

Rommadon commented May 26, 2023

What happened?

Following XCode 14, Apple has depricated support for Bitcode.

now causes a rejection in TestFlight/App Store with the following reason:
Screenshot 2566-05-26 at 09 48 48

If I build my project and run otool on it, it does indeed show that it contains bitcode:
otool -l OneSignal.framework/OneSignal | grep __LLVM -1
Screenshot 2566-05-26 at 10 01 53

On xcode build setting
Screenshot 2566-05-26 at 09 54 58
Screenshot 2566-05-26 at 09 54 53
Screenshot 2566-05-26 at 09 54 49
Screenshot 2566-05-26 at 09 54 36

On Podfile setting build ENABLE_BITCODE=NO
installer.pods_project.targets.each do |target| target.build_configurations.each do |config| config.build_settings["EXCLUDED_ARCHS[sdk=iphoneos*]"] = "armv7" config.build_settings['ENABLE_BITCODE'] = 'NO' config.build_settings['IPHONEOS_DEPLOYMENT_TARGET'] = '12.0' config.build_settings["EXCLUDED_ARCHS[sdk=iphonesimulator*]"] = "arm64" end end

And xcodebuild command I add ENABLE_BITCODE=NO But still have contains bitcode issue

Steps to reproduce?

Xcode 14.3
"react-native-onesignal": "^4.5.1"

`
  - OneSignalXCFramework (3.12.4):
    - OneSignalXCFramework/OneSignalCore (= 3.12.4)
    - OneSignalXCFramework/OneSignalExtension (= 3.12.4)
    - OneSignalXCFramework/OneSignalOutcomes (= 3.12.4)
  - OneSignalXCFramework/OneSignalCore (3.12.4)
  - OneSignalXCFramework/OneSignalExtension (3.12.4):
    - OneSignalXCFramework/OneSignalCore
    - OneSignalXCFramework/OneSignalOutcomes
  - OneSignalXCFramework/OneSignalOutcomes (3.12.4):
    - OneSignalXCFramework/OneSignalCore
`

and upload .ipa to TestFlight

What did you expect to happen?

without any issue

React Native OneSignal SDK version

4.5.1

Which platform(s) are affected?

  • iOS
  • Android

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@jennantilla
Copy link
Contributor

Hi @Rommadon thanks for your patience!

Based on the info you've provided, it appears that you are already using the latest version of XCode and have set ENABLE_BITCODE to No in both the project and library settings.

We had a similar issue a while back that was resolved by updating CocoaPods. Could you give that a go and let us know the results?

@jennantilla
Copy link
Contributor

@Rommadon just following up to see if you're still having issues.

@jennantilla
Copy link
Contributor

Closing due to no response. Please feel free to let us know if you are still having issues!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants