Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: VAPT issue found in react-native-onesignal for android. #1465

Closed
2 of 3 tasks
somasekharkakarla opened this issue Dec 8, 2022 · 1 comment
Closed
2 of 3 tasks

Comments

@somasekharkakarla
Copy link

somasekharkakarla commented Dec 8, 2022

What happened?

Our application recently went through VAPT. The team got back with a 2-low vulnerability

  1. The following activities are marked as exported in the manifest file, but those are not protected by any permissions. This can expose the mentioned activity to malicious apps running on the device.
    Activity (com.onesignal.NotificationOpenedActivityHMS)
    Activity
    (com.onesignal.NotificationOpenedReceiver) is not Protected. [android:exported=true]

  2. The following receiver are exported, but not protected by any permissions. Failing to protect receiver could leave them vulnerable to attack by malicious apps. The receiver should be reviewed for vulnerabilities, such as injection and information leakage.
    Broadcast Receiver (com.onesignal.UpgradeReceiver)
    (com.onesignal.BootUp Receiver), (com.onesignal. NotificationDismissReceiver),
    (com.onesignal. FCMBroadcastReceiver) is not Protected.
    [android:exported=true]

Screenshot 2022-12-08 at 5 59 12 PM

@BritOneSignal @dean-onesignal @mtsay-onesignal Please hot-fix it and release it.

Steps to reproduce?

VAPT process

What did you expect to happen?

No VAPT Issues

React Native OneSignal SDK version

4.3.1

Which platform(s) are affected?

  • iOS
  • Android

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@jennantilla
Copy link
Contributor

@somasekharkakarla apologies that this issue was missed. Since it's been quite some time since this was opened, I will be closing it due to inactivity. If you still have concerns surrounding penetration tests, please @ mention me and we can pick back up the conversation!

We have released a new User Model major release that offers many improvements and enhancements. I'd highly recommend upgrading to our latest SDK version and checking it out! Please see our migration guide for full details!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants