Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to use layer name "constants" rather literal values? #18

Open
follower opened this issue Nov 28, 2016 · 0 comments
Open

Refactor to use layer name "constants" rather literal values? #18

follower opened this issue Nov 28, 2016 · 0 comments

Comments

@follower
Copy link
Contributor

For clarity, it would be nice to have layer names rather than layer numbers (e.g. layers: [ 21, 25, 29, 51 ],) in the code.

The mixed-case nature of the standard Eagle layer names is unfortunate and it's not immediately clear what constant naming convention might be best (especially given JS's support/lack "const" and enums).

Maybe one of these styles:

// tDocu
EAGLE_LAYER_tDocu
LAYER_tDocu
EAGLE_LAYER_TDOCU
LAYER_TDOCU
layer.tDocu
layer.tDocu.id

Or something...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant