Internal class WorkspaceConfigurationProvider is returned from Public APIs

[gfs]

Problem

WorkspaceConfigurationProvider [1] is an internal class but it is returned from the public GetConfiguration API.

The GetConfiguration API [2] returns multiple Providers, and I'd like to be able to distinguish between them, as VS Code configuration for a Language Client end up in a WorkspaceConfigurationProvider. However, since WorkspaceConfigurationProvider is internal you cannot type check it.

Proposed Solution

Make WorkspaceConfigurationProvider Public.

Code References

[1]

csharp-language-server-protocol/src/Server/Configuration/WorkspaceConfigurationProvider.cs

Line 7 in be43bab

internal class WorkspaceConfigurationProvider : ConfigurationProvider

[2]

csharp-language-server-protocol/src/Protocol/Server/ILanguageServerConfiguration.cs

Line 31 in be43bab

Task<IConfiguration> GetConfiguration(params ConfigurationItem[] items);