Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repo Support Status? #1221

Open
Simonl9l opened this issue Apr 16, 2024 · 3 comments
Open

Repo Support Status? #1221

Simonl9l opened this issue Apr 16, 2024 · 3 comments

Comments

@Simonl9l
Copy link

Inquiring minds!

Given the significant C# change to no longer use OmniSharp for the C# VSCode experience, beyond Omnisharp being used in bicep, what is the real drivers to ensure this repo continues to be maintained.

For others that have built C# based LPS's using OmniSharp, this is critical, as for C# there are limited alternatives.

It can be observed that there are a number of chore pull requests for version bumps that have not been merged.

There are also a number of issues that have gone unanswered.

It seem at this point this repo is not even in "Support Mode"? It would be great the maintainer could updated the status here.

Also it seem there was a plan to migrate this set of repos to .Net Foundation support as indicated on the communications page, but this issue set to show this is still a work in progress.

@andyleejordan
Copy link
Contributor

I would also like to know, as the maintainer of the PowerShell Extension for VS Code I'm completely dependent on this project, since our LSP Server is implemented on top of it. We have half a million monthly active users so it's definitely in use and depended on.

@JoeRobich
Copy link
Member

Thanks for asking these questions. There is certainly a need for developers with time to contribute to these projects.

As a maintainer for the 1.x C# extension for VS Code, I contributed to OmniSharp-Roslyn (O#) and want to see it continue to be useful to the community. I've made an effort to contribute to this repo in order to light up new functionality in O#, but free time comes and goes.

I would say that O#'s goal is to remain an open-source, community-led C# Language Server. Which nowadays means having robust LSP support. If anyone has used O# in LSP mode within the VS Code C# extension, you will know that we are a ways away from that goal.

With that being said, I think the real value to the community is in having the O# Language Server not so much the LSP library. If the Roslyn team were to announce that their CLaSP library was supported, then I think we would need to consider moving O# to it in order to reduce the maintenance burden.

Having just moved back to the Roslyn team, I expect that I'll have a little more time to look at issues in O# and this repo, since my work life will be a bit more aligned with this work. However, I cannot commit myself to fixing issues that do not immediately impact or hinder O# running in VS Code.

@Simonl9l
Copy link
Author

@JoeRobich Thanks for taking the time to reply!

If I understand the Value Prop correctly, the LSP Library allows C# develops to build LSP's for their own languages. I'm not getting the nuance between O# (I assume OmniSharp) Language Server and the LSP Library?

Our use of OmniSharp is to build a LSP for our proprietary language to host inside a VSCode (and other IDE) extensions (wrapper).

Thanks for sharing the link to the CLaSP library, I've not delved to deeply; but do you suggest (if supported) this is a better toolset for developing LSP's for other languages in C#?

In the meantime are there any plans to update OmniSharp to C#12/.net8, including switching from NewtonSoft JSON to the Code Generated System.Text.Json parser, and more broadly avoiding reflection (or adding the requisite attributes), in support for AoT native builds? Of note .Net 6 is EOL November 12, 2024!

Thanks again, and anything that you can do to keep this code base maintained!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants