Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jQuery already sports 'addClass', 'removeClass', etc. features from 'classies.js` #22

Open
peterblazejewicz opened this issue May 1, 2015 · 0 comments

Comments

@peterblazejewicz
Copy link
Member

jQuery is already root dependency for website, so entire classie.js custom client code taken from 3rd party page seems to be not needed:
$.addClass
$.hasClass
$.removeClass
$.toggleClass
classie.js
https://github.com/OmniSharp/OmniSharp.github.io/blob/master/_includes/js.html#L2-L9

If the entire purpose of classie.js is to support other 3rd party script cbpAnimatedHeader.js used to animate top header:
https://github.com/OmniSharp/OmniSharp.github.io/blob/master/js/cbpAnimatedHeader.js
the code could be just rewritten, correctly referencing source of original code in banner.

Let me know what you think as I could do PR rewriting cbpAnimatedHeader.js to custom animate-header.js and removing 3rd party dependency (while retaining banner reference for feature idea)

The page would gain cleaner source code and will be slightly lighter (so will be loading faster).

Thanks!

Edit: I figured out that these JS codes come with freelancer 3rd party template.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant