Fix server crash (memory leak) #265
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Really to allow us to create a draft pr. But update was needed anyways.
sarhatabaot
added
the
bug: confirmed
There is no need to have variables static when we're using a singelton on the EvenMoreFish plugin class.
Most config files now go through "ConfigManager". This allows us to merge some common logic, and reduce the use of static variables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix the server crashes as outlined by a bunch of issues:
Closes #239
Closes #197
Closes #182
This is probably a memory leak, and not an NPE as outlined by the error messages themselves.
Any new findings will be included in this draft PR.