Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import flow in TTK, is pointing to Devpreview schema url with incorrect schema version (raw.githubusercontent.com) #11448

Closed
therealjohn opened this issue Apr 23, 2024 · 5 comments
Assignees
Labels
investigating needs attention This issue needs the attention of a contributor. TA:E2E Team Area: E2E

Comments

@therealjohn
Copy link
Contributor

Create an Outlook project using yo office command, with xml manifest
Go to TTK and try to import the project created
Check the converted manifest file.

"$schema": "https://raw.githubusercontent.com/OfficeDev/microsoft-teams-app-schema/preview/DevPreview/MicrosoftTeams.schema.json#", "manifestVersion": "devPreview",

So even for devpreview version, the schema URL should be
https://developer.microsoft.com/json-schemas/teams/vDevPreview/MicrosoftTeams.schema.json

Copy link
Contributor

Thank you for contacting us! Any issue or feedback from you is quite important to us. We will do our best to fully respond to your issue as soon as possible. Sometimes additional investigations may be needed, we will usually get back to you within 2 days by adding comments to this issue. Please stay tuned.

@microsoft-github-policy-service microsoft-github-policy-service bot added the needs attention This issue needs the attention of a contributor. label Apr 23, 2024
@adashen adashen added investigating TA:E2E Team Area: E2E labels Apr 24, 2024
@therealjohn
Copy link
Contributor Author

Per Darren,

Dependency references to office-addn-project package need to be updated to version 0.8.1. Any references to office-addin-manifest-converter (I'm not sure there are any) should be updated to version 3.1.0

@jayzhang
Copy link
Member

jayzhang commented Apr 25, 2024

The manifest.json file is generated by office-addin-project package.
By using office-addin-project@0.7.0, the output schema url is: https://raw.githubusercontent.com/OfficeDev/microsoft-teams-app-schema/preview/DevPreview/MicrosoftTeams.schema.json#
By using office-addin-project@0.8.1, the schema url is: https://developer.microsoft.com/json-schemas/teams/v1.17/MicrosoftTeams.schema.json#
So maybe @millerds can answer this question? Which version should TTK use?

@therealjohn
Copy link
Contributor Author

@jayzhang Confirmed with the team that we want it to point to 1.17, so to answer your question: Use office-addin-project@0.8.1.

@jayzhang
Copy link
Member

@therealjohn Yes. The fix will be in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
investigating needs attention This issue needs the attention of a contributor. TA:E2E Team Area: E2E
Projects
None yet
Development

No branches or pull requests

4 participants