Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WARNING in entrypoint size limit #516

Open
alexzhou-chata opened this issue Apr 24, 2023 · 7 comments
Open

WARNING in entrypoint size limit #516

alexzhou-chata opened this issue Apr 24, 2023 · 7 comments
Assignees

Comments

@alexzhou-chata
Copy link

Note: This repo is only for questions related to its samples. If you have questions about how to use office.js or the Office developer platform, please post your question on https://stackoverflow.com. Tag your question with office-js or outlook-web-addins

Question

When I run npm run build on this sample, it give the below warning.

WARNING in entrypoint size limit: The following entrypoint(s) combined asset size exceeds the recommended limit (244 KiB). This can impact web performance.
Entrypoints:
  vendor (1.13 MiB)
      vendor.[fullhash].js
  app (1.33 MiB)
      app.[fullhash].js

Could you please improve this issue?

@ghost ghost added the needs triage 🔍 label Apr 24, 2023
@AlexJerabek
Copy link
Collaborator

Hi @alexzhou-chata,

Thank you for reporting this issue. I have a couple of follow-up questions:

  1. Which sample is this related to?
  2. Is this impacting any development based on the sample?

@alexzhou-chata
Copy link
Author

Hi Alex,

I am so sorry that I didn't mention the specific sample.
The sample is Office-Add-in-Microsoft-Graph-React

No, this doesn't impact anything except for when user has a lower speed internet, this bundle size will affect the loading speed.
I built an app followed the sample and eventually had a chunk size more than 4MB, which is too large.
So, I came back to this sample to test how large of the asset size and found the size also too large.

All the best,
Alex Zhou

@AlexJerabek
Copy link
Collaborator

Thank you @alexzhou-chata. The large size of the react projects is a known issue from the yo office template.

@millerds is working on this issue, When we improve the template, we'll update this sample.

@alexzhou-chata
Copy link
Author

Thank you guys!

@AlexJerabek
Copy link
Collaborator

Reassigning to @millerds, since he's working on the two related issues.

@AlexJerabek AlexJerabek assigned millerds and unassigned AlexJerabek May 12, 2023
@aafvstam
Copy link
Collaborator

Is this still worked on, or completed @AlexJerabek @millerds ?

@AlexJerabek
Copy link
Collaborator

@aafvstam This is still an issue, but it's better tracked in the template repo. Since the related issues are still open, we can close and avoid redundancy.

OfficeDev/Office-Addin-TaskPane-React#92
OfficeDev/Office-Addin-TaskPane-React#119

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants