Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include devcontainer.json file in sample apps to open in codespaces #1200

Open
dbondarenkoms opened this issue Mar 18, 2024 · 2 comments
Open
Assignees

Comments

@dbondarenkoms
Copy link

Hello,

I’ve noticed that the sample app templates in the MS Teams sample apps repository currently do not include a devcontainer.json file. This file is essential for setting up a development environment in GitHub Codespaces, which can significantly streamline the process of testing and developing teams apps.

Including a devcontainer.json file would provide developers with a pre-configured development environment that includes all the necessary tools and extensions for working with the sample apps. This would not only make it easier for developers to get started but also ensure consistency across different development setups.

I believe adding this file to the sample apps templates would greatly benefit the community and enhance the overall developer experience. It would be much appreciated if this could be considered for future updates.

Thanks!

@ChetanSharma-msft
Copy link
Collaborator

Hello @dbondarenkoms - Thanks for sharing your inputs.
We will look into it and let you know the updates.

@Meghana-MSFT
Copy link

Meghana-MSFT commented Mar 19, 2024

@dbondarenkoms - We shared the above feedback with the sample development. Team will discuss internally and make necessary changes. Thank you.

Update : We received a confirmation from engineering team that we need not to add it for the Samples. A PR has been raised for one of the samples but it wont be added for all samples. https://github.com/OfficeDev/Microsoft-Teams-Samples/pull/1223/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants