Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support keepalives on WebSockets #588

Open
LukeButters opened this issue Dec 18, 2023 · 0 comments
Open

Support keepalives on WebSockets #588

LukeButters opened this issue Dec 18, 2023 · 0 comments

Comments

@LukeButters
Copy link
Contributor

LukeButters commented Dec 18, 2023

KeepAlives are a useful way of keeping open TCP connections and detecting if a TCP connection is broken, including in the case of a non graceful TCP termination. We have enabled TCP keepalives for listening and polling tentacles as described in OctopusDeploy/OctopusTentacle#692 . Doing so allows Halibut to detect failed connections allowing the caller to retry sooner and in the case of polling tentacles allows for the Polling tentacle to establish a new working connection sooner.

Currently we don't support TCP keepalives for Polling WebSockets as dicussed in this PR, we found that keep alives were only working with TCP connections, not web sockets.

Ideally we should support TCP keepalives with websocket, in this way TCP connectoons that are not gracefully terminated can be detected earlier allowing for callers to be told earlier that the RPC has failed allowing them to retry sooner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant