Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce that HalibutProxyRequestOptions is provided on each RPC call, forcing callers to provide CancellationToken[s] #586

Open
LukeButters opened this issue Dec 18, 2023 · 0 comments

Comments

@LukeButters
Copy link
Contributor

Currently the client proxy interface is permitted to not supply a HalibutProxyRequestOptions, which means the caller does not provide a CancellationToken so the code must generate CancellationToken.None and the caller has no way of cancelling that token.

This also lead to situations in which the code needs to do null checking to see if the HalibutProxyRequestOptions are passed or not.

To complete this we should enforce that HalibutProxyRequestOptions must be provided for every RPC call e.g. the client service contracts must support this parameter and the Proxy enforces it is not null.

See details here #525 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant