Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataStream.FromString does not pass the cancellation token, meaning we wont respect cancelled RPC calls. #585

Open
LukeButters opened this issue Dec 18, 2023 · 0 comments

Comments

@LukeButters
Copy link
Contributor

Since the CancellationToken is not passed, if an RPC call is cancelled the cancellation of the cancellation token wont result in the write being cancelled resulting in Halibut taking longer to cancel the call.

This can be worked around by using one of the other DataStream constructor methods.

Note that stream timeouts still apply, so Halibut can not be stuck forever in the write.

The issue is in the code below.
image

@LukeButters LukeButters changed the title DataStream.FromString does not pass the cancellation token, meaning we wont respect cancelled API calls. DataStream.FromString does not pass the cancellation token, meaning we wont respect cancelled RPC calls. Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant