Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Abandoned Plugin] Custom Control Editor #982

Open
trufy opened this issue Jan 13, 2022 · 12 comments
Open

[Abandoned Plugin] Custom Control Editor #982

trufy opened this issue Jan 13, 2022 · 12 comments

Comments

@trufy
Copy link

trufy commented Jan 13, 2022

Which Plugin?

https://plugins.octoprint.org/plugins/customControl/

Link to ticket on plugin's issue tracker confirming abandonment

https://github.com/Salandora/octoprint-customControl

Is there someone open to adopting it?

No response

@jneilliii
Copy link
Contributor

The plugin's readme says it's being developed again, so not sure if this is actually abandoned or not. @Salandora could you please verify one way or another?

@synman
Copy link
Contributor

synman commented Feb 9, 2022

@jneilliii I've been directing people to your fork where you fixed the "delete all custom commands" on restart bug.

https://github.com/jneilliii/octoprint-customControl/archive/devel.zip

@foosel
Copy link
Member

foosel commented Feb 26, 2022

@jneilliii that "actively worked on" status has been in there for almost two years now with no changes however, and I also haven't seen any activity from @Salandora on GitHub in quite a while. Which is totally fine, priorities shift, but considering that this particular plugin also has a somewhat nasty bug for the same almost two years now which has been fixed on your version but still not merged, I reached out on the plugin repo yesterday and am leaning towards declaring this one as abandoned if we don't hear anything back in terms of actual activity and a change to the bug situation in 14d.

Salandora/octoprint-customControl#42

As things stand now, people will install, the bug will strike somewhat later, and frustration is the result.

@synman
Copy link
Contributor

synman commented Feb 26, 2022

Would hate to see this abandoned, but yeah, it clearly is. Is there anything else out there that makes setting up custom controls easy via a UI?

@jneilliii
Copy link
Contributor

No, it's the only one. I would be willing to adopt the plugin since it's technically not that different than event manager plugin and probably doesn't need much changes to remain functional. I'm still a firm believer that any setting outside of "plugins" should be part of Core though.

@synman
Copy link
Contributor

synman commented Feb 26, 2022

I was thinking similarly but was going leave it alone until you mentioned it. How often do plugins make their way into the core build? I've seen core components become core plugins (gcode viewer). I am not familiar enough with the history of the platform to weigh the value / direction one way or another.

@jneilliii
Copy link
Contributor

jneilliii commented Feb 26, 2022

I think GCODEViewer was the only one that has gone the other way from core to plugin. I can only think of Event Manager that has been added since plugin ecosystem was created, maybe pi support plugin wasn't there at the beginning but can't really remember. Of course it and cura legacy were extracted out into their own repos for managing updates separately outside of core.

@cp2004
Copy link
Member

cp2004 commented Feb 26, 2022

3rd party plugins don't really end up becoming included in core as a bundled plugin, when I've looked back at history it is either new features in core being made as bundled plugins (usage tracking, error tracking, printer dialogs/notifications, etc.) or core components being extracted into plugins. I'm not aware of any time where it's happened before.

@synman
Copy link
Contributor

synman commented Feb 26, 2022

I guess it boils down to how important are maintaining custom controls to the functionality of the overall ecosystem. There is some decent core functionality being exposed already to make this capability available. I've used it within my own plugin to maintain custom controls functionality similar to what is exposed in the core control tab.

It's some pretty cool stuff. I was surprised how easy it was to pull it all together given what the framework provides.

The only missing piece IMHO is a sure fire way to manage them in a WYSIWYG manner.

@foosel
Copy link
Member

foosel commented Feb 26, 2022

I'm willing to make it a core plugin.

@Salandora
Copy link
Contributor

@foosel sorry for the late replay, go for it.
I will probably not continue on any of my plugins for the time being.
I don't really have time to print nowadays.

Feel free to open a Abandoned for the rest of my plugins too or if you want put them as a core plugin.

@foosel
Copy link
Member

foosel commented Jun 21, 2022

See OctoPrint/OctoPrint#4526

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

6 participants