Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github Actions Link Checker #521

Open
jneilliii opened this issue Jun 8, 2020 · 2 comments
Open

Github Actions Link Checker #521

jneilliii opened this issue Jun 8, 2020 · 2 comments

Comments

@jneilliii
Copy link
Contributor

I just noticed a couple of my plugins that were recently merged were missing screenshots, and after looking into it, issue seemed to be related to invalid links, both in the featured image section and within the detailed description at the bottom. I think this is a result of switching from Travis to Github Actions as the Travis build would error if links were invalid. I remember the checks would not pass before if the links didn't work.

@jneilliii jneilliii changed the title Link Checker Github Actions Link Checker Jun 8, 2020
@foosel
Copy link
Member

foosel commented Jun 12, 2020

There's now a link checker as part of the validation steps.

@foosel foosel closed this as completed Jun 12, 2020
@foosel
Copy link
Member

foosel commented Jun 12, 2020

Turns out the link check caused the build to run into rate limiting issues, so I had to disable it again. Might have to use a different check, ideally with result caching between checked pages (the one right now checks links that are included in the footer for example again and again and again)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

2 participants