Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Abandoned Plugin] TouchUI #1126

Open
roblandry opened this issue Dec 1, 2022 · 32 comments
Open

[Abandoned Plugin] TouchUI #1126

roblandry opened this issue Dec 1, 2022 · 32 comments
Labels
abandoned plugin help wanted

Comments

@roblandry
Copy link

Which Plugin?

https://plugins.octoprint.org/plugins/touchui/

Link to ticket on plugin's issue tracker confirming abandonment

BillyBlaze/OctoPrint-TouchUI#535

Is there someone open to adopting it?

No response
@jneilliii jneilliii mentioned this issue Dec 2, 2022
Merged
@wwian
Copy link

wwian commented Dec 2, 2022 •
edited

sad face. I still use this app with my prints.

@imjosecampos
Copy link

What’s the process to take this over? Fork and re-submit?

@jneilliii
Copy link
Contributor

Fork, address any outstanding major issues relative to compatibility, etc. bump version and submit PR to redirect the update checks. A good example can be found here of such a PR.

@imjosecampos
Copy link

Sounds good, will install and check the issues to see how much work may be involved and report back.

@vexofp
Copy link

vexofp commented Dec 4, 2022

Probably the biggest issue is an incompatibility with Octoprint 1.8.0+. See BillyBlaze/OctoPrint-TouchUI#532 for more info.

There is a link in there to a branch I made and have been using locally that fixed that problem, but I was never entirely happy with it because it broke backwards compatibility with older Octoprint versions. Maybe that is less of a problem now, since 1.8.0 has been out for awhile now? Either way, hopefully it helps!

@JohnathonMohr
Copy link

I've been wondering what happened to the temp graph. 😅

Well, if the plugin transfers ownership, that would provide a convenient time to shift compatibility to 1.8.0+. Just my 2 cents.

@sfarkhan
Copy link

I use TouchUI as well. I would be up to Patreon someone to take over. It's a popular plugin

@TheNore
Copy link

TheNore commented Feb 16, 2023 •
edited

Has there been any update on this? I use this on all of my printers, I would gladly donate to whoever took this over, its a great Plugin!! It would be a shame to loose it.

@jneilliii
Copy link
Contributor

but I was never entirely happy with it because it broke backwards compatibility with older Octoprint versions

You could do a copy of the file and conditionally load the different file based on OctoPrint version. Here's an example of where I've used this.

https://github.com/jneilliii/OctoPrint-TPLinkSmartplug/blob/27d265aadf164f2f2aebad99ef64874af029d869/octoprint_tplinksmartplug/__init__.py#L337

Also, it's always better to utilize id css selector if at all possible, just not sure without looking directly at it if that's available here or not.

@Thierry-Myron
Copy link

So sad... Still using on 10.1 touchscreen :(

@roblandry roblandry mentioned this issue Feb 28, 2023
Closed
@Unn4m3DD
Copy link

Unn4m3DD commented Mar 1, 2023

I'm considering taking a look at the plugin, fixing the graph, and maybe some quality-of-life updates, just asking here if someone else is already on it so that we don't duplicate our efforts

@imjosecampos
Copy link

Go for it. I was going to but work picked up and this fell off my plate

@Unn4m3DD
Copy link

Unn4m3DD commented Mar 1, 2023

Well, I have it sorted out. I've created a fork with the changes, can someone help me with how to make the update reach octoprints repositories? https://github.com/Unn4m3DD/OctoPrint-TouchUI
image

@vexofp
Copy link

vexofp commented Mar 5, 2023

@Unn4m3DD , I think the legend and temperature values at the bottom there still look messed up. They should look like this:
image

Please feel free to steal from BillyBlaze/OctoPrint-TouchUI@master...vexofp:532-temp-graph-1.8.x (if helpful)!

@Unn4m3DD
Copy link

Unn4m3DD commented Mar 8, 2023

I thought those bars were sliders xD I managed to get to this, should be close enough
image

@Unn4m3DD
Copy link

Heyy, I have had the PR opened for some time and I'm wondering if I did it in the correct way. @vexofp, you seem to know your way around the octoprint community, any chance you might be able to help me understand this?

@jneilliii
Copy link
Contributor

If you want to adopt the plugin it's just a matter of submitting a PR here that configures the correct update check overlays, the plugin listing data adding you as an author and a bumped version with release on your fork of the plugin. Here is an example of a completed adoption PR to see what I mean.

https://github.com/OctoPrint/plugins.octoprint.org/pull/1157/files

@ThatMattCraig
Copy link

I'll take this over. Ill try my best to keep it running for now

@pzwe2020
Copy link

My friend and i would love to transform this project and fix it. We will work our hardest on keeping it up. We just need someone to convert everything to python! I am new to get hub, and need to know how to take over the project.

@pzwe2020
Copy link

*Github

@Mbayazeed
Copy link

can't get a cam stream either !!

@devildant
Copy link
Contributor

Good morning,
unfortunately I don't have time to resume this plugin, however I made a fix for the webcam on my fork if you want:
https://github.com/devildant/OctoPrint-TouchUI

just download the master branch as zip, and install manually inside octoprint

@devildant
Copy link
Contributor

devildant commented Jun 23, 2023 •
edited

Note: I applied the fix from @Unn4m3DD + fix temp graph settings + fix the SD card symbol in the files section

@devildant
Copy link
Contributor

image

image

image

@Mbayazeed
Copy link

Mbayazeed commented Jun 25, 2023 via email

@chuwy5
Copy link

chuwy5 commented Aug 5, 2023

is someone maintaining it? if not depending on the code I might be willing to tip my hat in to atempt to keep it going

@devildant
Copy link
Contributor

is someone maintaining it? if not depending on the code I might be willing to tip my hat in to atempt to keep it going

at the moment there is no one to take over, i just made patches on my branch to fix the problems on the latest version of octoprint. if you want to resume the project, go go :), it will please a lot of people

@pzwe2020
Copy link

pzwe2020 commented Aug 5, 2023 via email

@chuwy5
Copy link

chuwy5 commented Aug 6, 2023 via email

@JayroJones
Copy link

Jesus fucking christ, the plugin STILL works fine, and I'm tired of the UI nagging me to remove it because it's "abandoned" by it's creator. (Thanks for that, douche.) How do I get it to stop nagging my system, even-though I always hit "Mark as read."? The nag is annoying as fuck to deal with, but the plugin is too useful to get rid of.

@cp2004
Copy link
Member

cp2004 commented Sep 2, 2023

@JayroJones - I suggest you choose a different tone so that you come across as a reasonable human being. Please check https://octoprint.org/conduct/.

Marking as read sets a cookie so the notification doesn't show again. If you're having trouble with this, I'd suggest politely trying to seek help on the community forums with appropriate gratitude for anyone who now decides to help you, and remember first impressions count.

@K1Printing
Copy link

If someone adopts this plugin and continues it's maintenance I'd be happy to chip in via patreon or something like that, I would take a crack at it, but I don't have the time or resources to learn programming at this given moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
abandoned plugin help wanted
Projects
OctoPrint Backlog
Status: Todo
Milestone
No milestone
Development

No branches or pull requests