Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request]Modify Text on GCode Viewer UI (clarify that some values reset by code) #5010

Open
sbaeder opened this issue May 7, 2024 · 1 comment
Labels
request Feature request

Comments

@sbaeder
Copy link

sbaeder commented May 7, 2024

Is your feature request related to a problem? Please describe.

The "problem" was that I couldn't for the life of me understand WHY the center and zoom options on the Render Options section of the UI were constantly being reset to OFF (unchecked), so I went digging in the code. I think I understand the why (i.e. due to conflicts with using the mouse to move/zoom things), but that should be made clearer on the UI.

Describe the solution you'd like

Maybe put an Asterix (*) after the text and a footnote that these get disable if the mose is used to actually pan/zoom inside the viewport.

Also, I don't see why these are not able to be saved somehow, and restored as the default when a new model is loaded/printed. I don't use the mose to change the zoom, and use the UI modifications to allow a smaller version of the display to exist in the side bar, and always want that ti show the zoomed in layers it is printing.

Describe alternatives you've considered

No response

Additional context

Anyway - just a thought to make it better for someone else. Keep the Faith!

@github-actions github-actions bot added the request Feature request label May 7, 2024
@jneilliii
Copy link
Contributor

Also, I don't see why these are not able to be saved somehow, and restored as the default when a new model is loaded/printed.

relative to this statement, the enabled options are saved to the browser's local storage and should reset if you were to refresh the page I think.

self._toLocalStorage = function () {
saveToLocalStorage(optionsLocalStorageKey, {
centerViewPort: self.renderer_centerViewport(),
zoomOnModel: self.renderer_zoomOnModel(),
showMoves: self.renderer_showMoves(),
showRetracts: self.renderer_showRetracts(),
showPrinthead: self.renderer_showPrinthead(),
showSegmentStarts: self.renderer_showSegmentStarts(),
showDebugArcs: self.renderer_showDebugArcs(),
chromeArcFix: self.renderer_chromeArcFix(),
showPrevious: self.renderer_showPrevious(),
showCurrent: self.renderer_showCurrent(),
showNext: self.renderer_showNext(),
showFullsize: self.renderer_showFullSize(),
showBoundingBox: self.renderer_showBoundingBox(),
showLayerBoundingBox: self.renderer_showLayerBoundingBox(),
hideEmptyLayers: self.reader_hideEmptyLayers()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
request Feature request
Projects
Status: Todo
Development

No branches or pull requests

2 participants