At commands are currently case sensitive, so @PAUSE doesn't trigger a pause whereas @pause does

[jneilliii]

The problem

When working through an issue with one of my plugins (https://github.com/jneilliii/OctoPrint-PauseManagement) I've come to realize that @PAUSE expanded by the gcode queuing phase are not processed by OctoPrint so the pause doesn't happen.

Did the issue persist even in safe mode?

I cannot test this issue in safe mode (state why below)

If you could not test in safe mode, please state why ("currently printing" is NOT an excuse!)

issue dependent on plugin hooks

Version of OctoPrint

1.9.3+

Operating system running OctoPrint

OctoPi 1.1.0 (nightly not sure what date)

Printer model & used firmware incl. version

Virtual

Browser and version of browser, operating system running browser

Google Chrome Version 123.0.6312.122 (Official Build) (64-bit)

Checklist of files to include below

• Systeminfo Bundle (always include!)
• Contents of the JavaScript browser console (always include in cases of issues with the user interface)
• Screenshots and/or videos showing the problem (always include in case of issues with the user interface)
• GCODE file with which to reproduce (always include in case of issues with GCODE analysis or printing behaviour)

Additional information & file uploads

octoprint-systeminfo-20240412155418.zip

Flexi-Rex-improved.gcode.txt

plugin settings

when you select the file it will extract any found pause commands (based on settings) and list in sidebar. delete them all and then add one for layer 1. I used the additional_logging branch to verify the setting was getting detected properly and shown in octoprint.log.

[foosel]

At commands are case sensitive ;) With @pause - as documented - it works.

However it might make sense to change that indeed, given that gcode is also case insensitive, so I'll look into that.

[foosel]

Well, that took longer than expected due to having to yak shave an issue with the CI build (setuptools update changed the name of the sdist tarball - fun times).

Anyhow, implemented by the above commit, will be part of 1.11.0.