Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can not upload multiple files if "Upload to SD" (aka streaming) is disabled via uncheckiing "Enable SD supprt" #4952

Closed
2 of 4 tasks
solidus0079 opened this issue Feb 17, 2024 · 4 comments
Labels
bug Issue describes a bug bugfix release relevant Issue should be looked at for backporting into the next bugfix release done Done but not yet released
Milestone

Comments

@solidus0079
Copy link

The problem

  1. I wanted to disable the "Upload to SD" button (aka streaming gcode) since I click it by accident sometimes and it takes forever.
  2. That button is removed by unchecking "Enable SD support" in Settings -> Features
  3. With "Enable SD support" unchecked, you can no longer upload multiple .gcode files at once via the remaining "Upload" button. Multiple files at once was possible when the "Enable SD support" button was checked, but the functionality goes away when it is unchecked.

Did the issue persist even in safe mode?

Yes, it did persist

If you could not test in safe mode, please state why ("currently printing" is NOT an excuse!)

Occurs in safe mode.

Version of OctoPrint

OctoPrint 1.9.3

Operating system running OctoPrint

OctoPi

Printer model & used firmware incl. version

Sovol SV06 2.0.0.A

Browser and version of browser, operating system running browser

Brave v1.62.165

Checklist of files to include below

  • Systeminfo Bundle (always include!)
  • Contents of the JavaScript browser console (always include in cases of issues with the user interface)
  • Screenshots and/or videos showing the problem (always include in case of issues with the user interface)
  • GCODE file with which to reproduce (always include in case of issues with GCODE analysis or printing behaviour)

Additional information & file uploads

Hopefully I did this right, first time. :)
octoprint-systeminfo-20240217122734.zip
10.0.0.58-1708191087103.log

@cp2004
Copy link
Member

cp2004 commented Feb 17, 2024

That'll be something I missed in #4633, so I've fixed it with #4953

Since 1.10 is already in RC phase, it will probably be in 1.11.

@cp2004 cp2004 added bug Issue describes a bug pr pending A pull request addressing this has been submitted but not yet merged and removed triage This issue needs triage labels Feb 17, 2024
@foosel foosel added this to the 1.11.0 milestone Mar 18, 2024
@foosel foosel added the bugfix release relevant Issue should be looked at for backporting into the next bugfix release label Mar 18, 2024
@foosel foosel added done Done but not yet released and removed pr pending A pull request addressing this has been submitted but not yet merged labels Apr 16, 2024
@foosel
Copy link
Member

foosel commented Apr 16, 2024

Just merged your PR after fixing the issue with it. I've also marked this as bugfix release relevant, so it might also end up in a future 1.10.x bugfix release after stable is out.

@foosel
Copy link
Member

foosel commented Apr 25, 2024

Backported to 1.10.1.

@foosel foosel modified the milestones: 1.11.0, 1.10.x Apr 25, 2024
@foosel
Copy link
Member

foosel commented May 14, 2024

1.10.1 has just been released.

@foosel foosel closed this as completed May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue describes a bug bugfix release relevant Issue should be looked at for backporting into the next bugfix release done Done but not yet released
Projects
Status: Done
Development

No branches or pull requests

3 participants