- Your changes are not possible to do through a plugin and relevant to a large audience (ideally all users of OctoPrint)
- If your changes are large or otherwise disruptive: You have made sure your changes don't interfere with current development by talking it through with the maintainers, e.g. through a Brainstorming ticket
- Your PR targets OctoPrint's
devel
branch if it's a completely new feature, ormaintenance
if it's a bug fix or improvement of existing functionality for the current stable version (no PRs againstmaster
or anything else please) - Your PR was opened from a custom branch on your repository
(no PRs from your version of
master
,maintenance
, ordevel
please), e.g.dev/my_new_feature
orfix/my_bugfix
- Your PR only contains relevant changes: no unrelated files, no dead code, ideally only one commit - rebase and squash your PR if necessary!
- Your changes follow the existing coding style
- If your changes include style sheets: You have modified the
.less
source files, not the.css
files (those are generated withlessc
) - You have tested your changes (please state how!) - ideally you have added unit tests
- You have run the existing unit tests against your changes and nothing broke
- You have added yourself to the
AUTHORS.md
file :)