Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Events header should show epoch instead of block #81

Open
Thegaram opened this issue Apr 6, 2021 · 2 comments
Open

Events header should show epoch instead of block #81

Thegaram opened this issue Apr 6, 2021 · 2 comments

Comments

@Thegaram
Copy link

Thegaram commented Apr 6, 2021

The header above the listed events should show epoch. It seems there's also some formatting issue, the field names are not aligned.

image

@leonlianght
Copy link
Collaborator

We do have both blockNumber and epochNumber it our data, do you think it is necessary to render both items?

For the alignment issue, it normally looks like:
image
It seems somehow it couldn't get the input names of the Event 'SendCfxToContract', could you help to check with the ABI?

@Thegaram
Copy link
Author

Thegaram commented Apr 9, 2021

I see, I used unnamed event arguments so that explains the UI issue.

pragma solidity >=0.5.0 <0.7.0;

contract Coin {
    event SendCfxToContract(address, uint256);

    function sendCfxToContract() public payable {
        uint256 amount = msg.value;
        emit SendCfxToContract(msg.sender, amount);
    }
}

As I remember, earlier versions listed the epoch number, not the block number. I personally think the epoch number would be more useful, but it's up to you whether you display one, the other, or both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants