Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CenterAction discussion #3

Open
apupier opened this issue Feb 26, 2018 · 0 comments
Open

CenterAction discussion #3

apupier opened this issue Feb 26, 2018 · 0 comments

Comments

@apupier
Copy link
Contributor

apupier commented Feb 26, 2018

There is currently a center action.
It is specified that it is resetting the zoom level to default. I was not expecting this behavior when reading the name of the action.

I think of several possibilities which I think would improve clarity:

  • rename to CenterAndResetZoomAction
  • have a Boolean parameter to reset the zoom or not, with false by default.
  • have 2 actions different to reset the zoom and to center and use a "composite action"

What do you think?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@apupier