Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve where clause? #27

Open
stufraser1 opened this issue Sep 8, 2021 · 1 comment
Open

Improve where clause? #27

stufraser1 opened this issue Sep 8, 2021 · 1 comment
Assignees
Labels
question Further information is requested

Comments

@stufraser1
Copy link
Collaborator

Further tests and fix required:
Can converter run successfully with a 'when:' clause and a fall-back transformation, either with or without another alternative 'when:' condition?

Ascot testing showed it transforms the field successfully transformation with a when: clause and apply it only to the correct subset, but I can’t get it to fall back to another transformation for those rows where the when: clause evaluates to false.

Line 152 of mapping yaml:
- transformation: Limit1
when: IsLayer is 'Y'
- transformation: SubLimitOcc

Here Limit1 gets pulled through correctly for the rows where IsLayer = Y, but the rows (with IsLayer = ’’) which should be SubLimOcc are coming through as blanks instead.
User should be able to string many conditionals together but it doesn’t seem to work (or will pick up only the first transformation).

@stufraser1
Copy link
Collaborator Author

User guide also needs to include practical examples of how to use when clauses, to assist users clearly (feedback shows users don't know what is possible yet).

@OmegaDroid OmegaDroid self-assigned this Dec 9, 2021
@stufraser1 stufraser1 added the question Further information is requested label Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants