Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invisible code parts - bright blue text on the blue background #1116

Open
mbiesiad opened this issue Dec 1, 2023 · 6 comments
Open

Invisible code parts - bright blue text on the blue background #1116

mbiesiad opened this issue Dec 1, 2023 · 6 comments
Labels
enhancement A new or improved feature for the WSTG or repo revise Needs quality review, updates, or revision

Comments

@mbiesiad
Copy link

mbiesiad commented Dec 1, 2023

What's the issue?
Text color used in combination with the background color makes it almost invisible.

How do we solve it?
Use other color (than presented at the screenshots below) for these code parts - not bright blue.

Would you like to be assigned to this issue?
No

Repro steps:

  1. Go to https://owasp.org/www-project-web-security-testing-guide/v41/4-Web_Application_Security_Testing/07-Input_Validation_Testing/18-Testing_for_Server_Side_Template_Injection
  2. Scroll down to see code parts (examples)

Screenshots ❌

image
or
image

Additional information

Please notice that current 'effect of colors' make it unuseful - better result is even if we use white text with uniformed background:
image

Best wishes,

@mbiesiad mbiesiad added help wanted revise Needs quality review, updates, or revision labels Dec 1, 2023
@kingthorin
Copy link
Collaborator

Unfortunately that's a failing of the OWASP Site theme. I'll look at getting this issue moved and the item addressed.

@kingthorin kingthorin added enhancement A new or improved feature for the WSTG or repo and removed help wanted labels Dec 1, 2023
@mbiesiad
Copy link
Author

mbiesiad commented Dec 2, 2023

Hi @kingthorin Thank you for quick reaction and message. I can see. Sounds great! ✨

@kingthorin
Copy link
Collaborator

kingthorin commented Dec 21, 2023

Dose this seem workable?
image
image

#F0F0F0

@mbiesiad
Copy link
Author

image

From my point of view, it's much better! ✔

@kingthorin
Copy link
Collaborator

Okay, I'll see if I can add some css/scss to override that for the wstg deployment(s).

@kingthorin
Copy link
Collaborator

I've tried a few things in a local environment without success. I'll ask around for other ideas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A new or improved feature for the WSTG or repo revise Needs quality review, updates, or revision
Projects
None yet
Development

No branches or pull requests

2 participants