Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] wxGUI: Nonsense commands end in Success in gconsole OnCmdDone method #3698

Open
lindakarlovska opened this issue May 9, 2024 · 0 comments
Labels
bug Something isn't working GUI wxGUI related

Comments

@lindakarlovska
Copy link
Contributor

Describe the bug

When any nonsense command is launched, it should end up in event.returncode != 0 on the row 767 in gconsole.py. Currently, it ends up in "Success" which is not correct. This problem was revealed during the implementation of the history tree since the status icons are selected according to the final command status.

To reproduce

Write e.g. v.impooort to Console (any nonsense works). This command is saved to the history browser tree with the icon status-success

Expected behavior

The final status in OnCmdDone should be False for nonsense cases so that the icon in the history tree will be automatically set to status-failed

System description

  • GRASS GIS version: development
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working GUI wxGUI related
Projects
None yet
Development

No branches or pull requests

1 participant