[Bug] PATH setting discrepancy between the main exectable and Python API for scripts on Windows

[wenzeslaus]

While the grass init script (the main executable) sets this:

    if not WINDOWS:
        path_prepend(gpath("scripts"), "PATH")
    path_prepend(gpath("bin"), "PATH")

the Python API in grass.script sets the following:

    path_addition = os.pathsep + os.path.join(gisbase, "bin")
    path_addition += os.pathsep + os.path.join(gisbase, "scripts")
    if WINDOWS:
        path_addition += os.pathsep + os.path.join(gisbase, "extrabin")

The difference in adding extrabin in grass.script is given by the fact that the init script on Windows is wrapped with a .bat script which sets extrabin, so the init script does not need to add that.

However, I'm not clear about scripts. On everything else except Windows, things are in scripts, but not on Windows. Is that correct? Should the new code be:

    path_addition = os.pathsep + os.path.join(gisbase, "bin")
    if WINDOWS:
        path_addition += os.pathsep + os.path.join(gisbase, "extrabin")
    else:
        path_addition += os.pathsep + os.path.join(gisbase, "scripts")

?