Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] Merge testsuite and test_suite directories for v.surf.rst. #3592

Open
HuidaeCho opened this issue Apr 13, 2024 · 5 comments
Open

[Feat] Merge testsuite and test_suite directories for v.surf.rst. #3592

HuidaeCho opened this issue Apr 13, 2024 · 5 comments
Labels
enhancement New feature or request tests Related to Test Suite vector Related to vector data processing

Comments

@HuidaeCho
Copy link
Member

There are two test directories for v.surf.rst.

  • test_suite/profile.sh
  • testsuite/test_vsurfrst.py.

Can we merge them?

@HuidaeCho HuidaeCho added enhancement New feature or request vector Related to vector data processing tests Related to Test Suite labels Apr 13, 2024
@echoix
Copy link
Member

echoix commented Apr 13, 2024

If they are correctly picked up by gunittest, yes.
By correctly picked up I mean that they are able to fail if they need to fail. For example, locally messing up the inputs or expected output, and making sure that gunittest fails.

testsuite should be the one kept.

@HuidaeCho
Copy link
Member Author

We need a unified directory name. From the contents of both directories, testsuite seems to be newer.

@echoix
Copy link
Member

echoix commented Apr 13, 2024

testsuite is the (only) one that gunittest looks for. tests is for pytest (until our unittest-based tests run with pytest, for now they can't).

test_suite or any other shell file not in the expected folder structure simply aren't run.

@HuidaeCho
Copy link
Member Author

testsuite is the (only) one that gunittest looks for. tests is for pytest (until our unittest-based tests run with pytest, for now they can't).

test_suite or any other shell file not in the expected folder structure simply aren't run.

Good to know that!

@echoix
Copy link
Member

echoix commented Apr 13, 2024

See also

#3362

#3358

And

#3358 (comment)

I didn't go any further since with the time I had, there weren't any more that could simply be renamed without bigger changes with the files themselves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request tests Related to Test Suite vector Related to vector data processing
Projects
None yet
Development

No branches or pull requests

2 participants