-
-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Hugo version to README #312
Comments
On grass.osgeo.org, we have currently (manually) installed:
If it doesn't break anything I can update it to a more recent version. |
I've been testing locally with 0.83 and haven't seen anything broken... so up to that version might be safe :) @nobeeakon have you tested with newer versions? |
I've bumped into the problem of having the blackfriday markdown renderer specified in the configuration when trying to setup a GitPod/GitHub Codespaces to easily contribute to the website. What are the differences in the build output when using one or the other? (Like a diff of the output of what the server deploys vs what we can build locally). Appart from the handling of invalid names for the We are now running with an already unsupported configuration, it's only working since the versions used are older. Why does the hosting server need to have a Hugo version? Doesn't a deploy mean to transfer the build contents to a web server, and not build it there where the access to debug what's going on is more limited? |
We do not (yet?) build the hugo pages here on Github. So far this repo is checked out on grass.osgeo.org, then hugo is run there and the resulting pages moved into the Apache http directory. Suggestions to do all this in a better way are most welcome. |
I edited the config file as in #310, i.e., to use goldmark and at least locally I do not see issues in the build with hugo 0.83. What problems do you bump into? What is changed with newer hugo versions if you switch to goldmark?
What would be the benefits of an update to newer hugo versions? Would you be willing to lead such an effort?
Do you have experience with other settings or suggestions on how to do it more efficiently? |
Update: we are planning to update grass.osgeo.org to Debian bookworm which ships hugo 0.111.3 according to Might the upgrade cause any troubles here? |
I have hugo v0.98.0 and it builds alright, must test with a newer version. @nobeeakon have you tried with the version mentioned by @neteler or newer? |
The breaking change is with v100.2 |
Thanks @echoix, is it clear for you what we need to do then? Would you be willing to test and create a PR? We can then merge once the update is in place? |
@veroandreo I'm on the road this week, so I can only do things on a phone, like searches and al. If I was on a computer, I'd build the website with the current Hugo version, copy the whole output contents in another folder, then redo the same thing with the current version + switching the markdown renderer, copy the build outputs, and compare the two outputs with something like |
Didn't see this issue before I created #394. I had issues with raw HTML not being rendered, so e.g. images were not shown at all, it needs to be allowed in the configuration. The rest looked fine, but I didn't check everything. |
Based on this comment I guess it would be between v0.69.0 and < v0.100.2 as v0.100.2 is not using the current defaultMarkdownHandler
The text was updated successfully, but these errors were encountered: