Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PkgConfig is (may be) used by the build system but not listed as dependency #863

Open
dvstans opened this issue Dec 8, 2022 · 1 comment
Labels
Component: Build Related to the build system Priority: High Highest priority Type: Docs - User User / admin documentation

Comments

@dvstans
Copy link
Collaborator

dvstans commented Dec 8, 2022

I'm not sure why PkgConfig is needed in the cmake build file. Need to determine if it really is needed and either document it, or remove it if it isn't needed.

@dvstans dvstans added Priority: High Highest priority Component: Build Related to the build system Type: Docs - User User / admin documentation labels Dec 8, 2022
@JoshuaSBrown
Copy link
Collaborator

It looks like I added that, it was necessary when ZeroMQ did not support fully the CMake package configuration files. Now they do, I think it can be removed and replaced, i.e. these lines can be changed I believe:

  ## load in pkg-config support
  find_package(PkgConfig)
  ## use pkg-config to get hints for 0mq locations
  pkg_check_modules(PC_ZeroMQ QUIET zmq)

  ## use the hint from above to find where 'zmq.h' is located
  find_path(ZeroMQ_INCLUDE_DIR
          NAMES zmq.h
          PATHS ${PC_ZeroMQ_INCLUDE_DIRS}
          )

  ## use the hint from about to find the location of libzmq
  find_library(ZeroMQ_LIBRARY
          NAMES zmq
          PATHS ${PC_ZeroMQ_LIBRARY_DIRS}
          )

  include_directories( ${ZeroMQ_INCLUDE_DIR} )
  link_directories( ${PC_ZeroMQ_LIBRARY_DIRS} )

To

find_package(ZeroMQ REQUIRED)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Build Related to the build system Priority: High Highest priority Type: Docs - User User / admin documentation
Projects
None yet
Development

No branches or pull requests

2 participants