Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build appraoch for nlohmann josn & validator #862

Open
dvstans opened this issue Dec 8, 2022 · 1 comment
Open

Build appraoch for nlohmann josn & validator #862

dvstans opened this issue Dec 8, 2022 · 1 comment
Labels
Component: Build Related to the build system Priority: High Highest priority Status: Discuss Needs discussion to determine proper disposition Type: Docs - Code Relates to code documentation

Comments

@dvstans
Copy link
Collaborator

dvstans commented Dec 8, 2022

Recently rebuilding DataFed on a new machine, I ran into the issue of the nlohmann josn and schema validator libraries not having released linux packages (they are GitHub open source projects). The process for installing these is also not documented. We should either document this, integrate these libraries directly into DataFed, or find better supported alternatives.

Note that the nlohmann json library is a dependency for the schema validator. If we move schema validation to the web api layer, we could remove both of these dependencies for the core server.

@dvstans dvstans added Priority: High Highest priority Type: Docs - Code Relates to code documentation Component: Build Related to the build system Status: Discuss Needs discussion to determine proper disposition labels Dec 8, 2022
@JoshuaSBrown
Copy link
Collaborator

I only have a comment on this, the devel branch now has a script for installing all dependencies that will automatically pull the repos down and build them.

I do not have a strong opinion on this yet, as I have not used these third-party packages much directly. I am always up for reducing dependencies if possible but I leave it up to your judgment as to how to proceed with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Build Related to the build system Priority: High Highest priority Status: Discuss Needs discussion to determine proper disposition Type: Docs - Code Relates to code documentation
Projects
None yet
Development

No branches or pull requests

2 participants