Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core repo config validation needs to be removed or improved #856

Open
dvstans opened this issue Oct 28, 2022 · 1 comment
Open

Core repo config validation needs to be removed or improved #856

dvstans opened this issue Oct 28, 2022 · 1 comment
Labels
Component: Core Relates to core service Type: New Feature New or enhanced feature

Comments

@dvstans
Copy link
Collaborator

dvstans commented Oct 28, 2022

There are some very basic checks that are run against repo configuration loaded from the DB. These checks are only good at detecting very basic config mistakes AND the errors are only reported to the log (no way for an admin to know about or view errors). It is probably better just to not validate these settings, then let the system fail when the repo is first used. This might produce an error that would lead admins to check the configuration. Alternatively, the system could validate the settings by pinging the repo servers when the settings are first entered or later changed.

@dvstans dvstans added Type: New Feature New or enhanced feature Component: Core Relates to core service labels Oct 28, 2022
@JoshuaSBrown
Copy link
Collaborator

Yes, I believe in hard failures on startup for things likes like this. I really dislike quiet failures for configuration issues that should be resolved on start.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Core Relates to core service Type: New Feature New or enhanced feature
Projects
None yet
Development

No branches or pull requests

2 participants