Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GDS] Add Method GetCertificates to GDS for Pull Support and ServerConfiguration for Push Support / Fix CheckRevocationStatus #2553

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

[GDS] Add Method GetCertificates to GDS for Pull Support and ServerConfiguration for Push Support / Fix CheckRevocationStatus #2553

wants to merge 16 commits into from

Conversation

romanett
Copy link
Contributor

@romanett romanett commented Mar 12, 2024 •
edited

Proposed changes

Adding the Method GetCertificates for Pull Model to the GDS:
https://reference.opcfoundation.org/GDS/v105/docs/7.9.8

And also to the Server for Push Support:

https://reference.opcfoundation.org/GDS/v105/docs/7.10.5

Additionally the GDS Client & Push client are updated with the new Method

Fix checkRevocationStatus Method to do an online Revocation check.

Related Issues

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds functionality)
  • Test enhancement (non-breaking change to increase test coverage)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected, requires version increase of Nuget packages)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc.
  • I have signed the CLA.
  • I ran tests locally with my changes, all passed.
  • I fixed all failing tests in the CI pipelines.
  • I fixed all introduced issues with CodeQL and LGTM.
  • I have added tests that prove my fix is effective or that my feature works and increased code coverage.
  • I have added necessary documentation (if appropriate).
  • Any dependent changes have been merged and published in downstream modules.

Further comments

@codecov Codecov
Copy link

codecov bot commented Mar 12, 2024 •
edited

Codecov Report

Attention: Patch coverage is 62.76596% with 35 lines in your changes are missing coverage. Please review.

Project coverage is 54.63%. Comparing base (a6f44c7) to head (2dcfd1c).

Files Patch % Lines
...pc.Ua.Gds.Server.Common/ApplicationsNodeManager.cs 44.00% 23 Missing and 5 partials ⚠️
...a.Server/Configuration/ConfigurationNodeManager.cs 78.57% 2 Missing and 1 partial ⚠️
...a.Gds.Client.Common/GlobalDiscoveryServerClient.cs 84.61% 1 Missing and 1 partial ⚠️
...Gds.Client.Common/ServerPushConfigurationClient.cs 88.23% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2553      +/-   ##
==========================================
- Coverage   54.64%   54.63%   -0.02%     
==========================================
  Files         342      342              
  Lines       65056    65140      +84     
  Branches    13335    13349      +14     
==========================================
+ Hits        35550    35587      +37     
- Misses      25641    25677      +36     
- Partials     3865     3876      +11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@romanett romanett self-assigned this Mar 21, 2024
@romanett romanett mentioned this pull request Mar 27, 2024
Open
5 tasks
@romanett romanett linked an issue Mar 27, 2024 that may be closed by this pull request
Plan to include GetCertificates API in the sdk #2567
Open
5 tasks
@romanett romanett added this to the April Update milestone Mar 29, 2024
@romanett romanett marked this pull request as ready for review April 4, 2024 18:27
@romanett romanett marked this pull request as draft April 15, 2024 13:56
@romanett romanett changed the title Add Method GetCertificates to GDS for Pull Support and ServerConfiguration for Push Support [GDS] Add Method GetCertificates to GDS for Pull Support and ServerConfiguration for Push Support / Fix CheckRevocationStatus Apr 15, 2024
@romanett romanett marked this pull request as ready for review April 18, 2024 14:53
@romanett romanett requested a review from mregen April 18, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mregen mregen Awaiting requested review from mregen

At least 1 approving review is required to merge this pull request.

Assignees

@romanett romanett

Labels
None yet
Projects
None yet
Milestone
April Update
Development

Successfully merging this pull request may close these issues.

Plan to include GetCertificates API in the sdk Make UA-.NETStandard GDS-Feature Complete
1 participant
@romanett