Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*DRAFT* Add EventMonitoredItem comfort #2543

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

*DRAFT* Add EventMonitoredItem comfort #2543

wants to merge 3 commits into from

Conversation

KircMax
Copy link
Contributor

@KircMax KircMax commented Mar 1, 2024

Proposed changes

This is not a proposal yet.
I just want to create a discussion basis in order to from that create a Pull Request that contains these changes in a way it will be okay to include this into the repository.
I just copied some Extensions I have currently build up on top of the MonitoredItem that make Event Handling easier for me.

Related Issues

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply. You can also fill these out after creating the PR.

  • Bugfix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds functionality)
  • Test enhancement (non-breaking change to increase test coverage)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected, requires version increase of Nuget packages)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc.
  • I have signed the CLA.
  • I ran tests locally with my changes, all passed.
  • I fixed all failing tests in the CI pipelines.
  • I fixed all introduced issues with CodeQL and LGTM.
  • I have added tests that prove my fix is effective or that my feature works and increased code coverage.
  • I have added necessary documentation (if appropriate).
  • Any dependent changes have been merged and published in downstream modules.

Further comments

I just want to kick off the discussion for how this could be done.
This is absolutely not final.

@codecov Codecov
Copy link

codecov bot commented Mar 1, 2024 •
edited

Codecov Report

Attention: Patch coverage is 4.66667% with 143 lines in your changes are missing coverage. Please review.

Project coverage is 54.35%. Comparing base (3f29a72) to head (9616b83).

Files Patch % Lines
Libraries/Opc.Ua.Client/MonitoredItem.cs 14.28% 40 Missing and 2 partials ⚠️
Libraries/Opc.Ua.Client/Methods/MethodBase.cs 0.00% 38 Missing ⚠️
Libraries/Opc.Ua.Client/Events/Extensions.cs 0.00% 27 Missing ⚠️
Libraries/Opc.Ua.Client/Events/OpcEvent.cs 0.00% 12 Missing ⚠️
....Client/Events/OpcUaEventFieldNotFoundException.cs 0.00% 10 Missing ⚠️
...ies/Opc.Ua.Client/Methods/EventMethodCollection.cs 0.00% 4 Missing ⚠️
...ies/Opc.Ua.Client/Methods/MethodCallReturnValue.cs 0.00% 4 Missing ⚠️
Libraries/Opc.Ua.Client/Methods/EventMethod.cs 0.00% 3 Missing ⚠️
Libraries/Opc.Ua.Client/Events/EventField.cs 0.00% 2 Missing ⚠️
Libraries/Opc.Ua.Client/Methods/OutputArgument.cs 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2543      +/-   ##
==========================================
- Coverage   54.45%   54.35%   -0.10%     
==========================================
  Files         335      344       +9     
  Lines       64749    64899     +150     
  Branches    13292    13312      +20     
==========================================
+ Hits        35256    35273      +17     
- Misses      25657    25785     +128     
- Partials     3836     3841       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@romanett romanett marked this pull request as draft March 11, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mregen mregen Awaiting requested review from mregen

At least 1 approving review is required to merge this pull request.

Assignees

@mregen mregen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

A&C Enhancements for the Client
2 participants
@KircMax @mregen