Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dropna in jan_adjustment will remove all values in row #34

Open
pricemg opened this issue Dec 18, 2020 · 0 comments
Open

dropna in jan_adjustment will remove all values in row #34

pricemg opened this issue Dec 18, 2020 · 0 comments

Comments

@pricemg
Copy link

pricemg commented Dec 18, 2020

adjusted = adjusted.dropna()

The above line in the function means if passing in a dataframe with the following format

date col1 col2
2019-01-01 101 NaN
... ... ...
2019-05-01 104 NaN
2019-06-01 103 100
... ... ...
2020-01-01 101 102

(i.e. col2 timeseries starts later than col1 ) then jan_adjustment will drop the entire row for 2019-01-01.

Not sure on the correct behaviour, but anecdotally removing the dropna seems to work well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant