Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sort eigenvalues and eigenvectors #653

Merged
merged 12 commits into from Dec 14, 2023
Merged

sort eigenvalues and eigenvectors #653

merged 12 commits into from Dec 14, 2023

Conversation

JoaquinViera
Copy link
Collaborator

closes #594

@JoaquinViera JoaquinViera marked this pull request as ready for review April 9, 2023 00:57
@codecov-commenter
Copy link

codecov-commenter commented Apr 9, 2023 •
edited by codecov bot

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (d0c72ed) 80.00% compared to head (c3a2ddf) 82.72%.
Report is 1 commits behind head on master.

Files Patch % Lines
examples/deployableRing/deployableRing.m 0.00% 2 Missing ⚠️
...ples/nonLinearAerodynamics/nonLinearAerodynamics.m 0.00% 1 Missing ⚠️
...CantileverBeam/onsasExample_rightAngleCantilever.m 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #653      +/-   ##
==========================================
+ Coverage   80.00%   82.72%   +2.71%     
==========================================
  Files         145      139       -6     
  Lines        4792     4642     -150     
==========================================
+ Hits         3834     3840       +6     
+ Misses        958      802     -156

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jorgepz
Copy link
Member

jorgepz commented Apr 10, 2023

excellent joaquin! I think that to add the feature we should add a test also, probably in the cantilever modal analysis... it would have to be an example where the modes are NOT obtained sorted and this sorts them out. we should discuss this.

@jorgepz jorgepz marked this pull request as draft August 26, 2023 18:10
@jorgepz jorgepz marked this pull request as ready for review December 13, 2023 19:01
@jorgepz jorgepz marked this pull request as draft December 13, 2023 20:28
jorgepz
jorgepz approved these changes Dec 13, 2023
View reviewed changes
Copy link
Member

@jorgepz jorgepz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the proposal @JoaquinViera i did some slight changes. However there are some more changes to add such as validation of the frequencies and change the section in the cantilever modal analysis example to improve the vtk mode plots

@jorgepz jorgepz marked this pull request as ready for review December 14, 2023 12:22
@jorgepz jorgepz merged commit 1ef3029 into master Dec 14, 2023
8 checks passed
@jorgepz jorgepz deleted the 594 branch December 14, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgepz jorgepz jorgepz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add sort of eigenvalues/modes in modal analysis
3 participants
@JoaquinViera @codecov-commenter @jorgepz