Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wake oscillator feature #468

Open
2 of 5 tasks
mvanzulli opened this issue May 5, 2022 · 10 comments · Fixed by #544
Open
2 of 5 tasks

Add wake oscillator feature #468

mvanzulli opened this issue May 5, 2022 · 10 comments · Fixed by #544
Labels
enhancement New feature or request
Milestone

Comments

@mvanzulli
Copy link
Member

mvanzulli commented May 5, 2022

This enhancement issue seek to generalize the ONSAS implementation in order to include the Wake Oscillator Model as an improvement of the aerodynamic forces.

  • add VIV function
  • change authorship list
  • change global VIV variables in hydroframe force to official fields in the input structs (analysissettings)
  • add initial $q$ value
  • include back a nonlinear aerodynamics test-example
@mvanzulli mvanzulli added the enhancement New feature or request label May 5, 2022
@mvanzulli mvanzulli added this to the version 0.3.0 milestone May 5, 2022
@mvanzulli mvanzulli changed the title Update ONSAS to new input format Add weak oscillator parameter q into ONSAS May 6, 2022
@ONSAS ONSAS deleted a comment from jorgepz May 7, 2022
@jorgepz jorgepz changed the title Add weak oscillator parameter q into ONSAS Add wake oscillator parameter q into ONSAS May 11, 2022
@jorgepz
Copy link
Member

jorgepz commented May 20, 2022

Not to be implemented yet.

@jorgepz jorgepz closed this as completed May 20, 2022
@jorgepz jorgepz changed the title Add wake oscillator parameter q into ONSAS Add wake oscillator feature May 26, 2022
@jorgepz
Copy link
Member

jorgepz commented May 26, 2022

I'll reopen this issue with a different approach. just including the WOM computation as an additional feature but not as monolithic by the moment.

@jorgepz jorgepz reopened this May 26, 2022
@jorgepz
Copy link
Member

jorgepz commented May 26, 2022

advances done in #504

@jorgepz
Copy link
Member

jorgepz commented Jul 27, 2022

the VIV function was added by @TheChikenfly in #518
we have yet to update the authorship list before closing this issue.

@TheChikenfly
Copy link
Collaborator

Amazing thanks!

@jorgepz
Copy link
Member

jorgepz commented Aug 24, 2022

We just fixed/optimized ONSAS assembler flow. and also updated the authors list.
To this issue description I just added "change global VIV variables to official fields in the input structs" . we can discuss this later.

@jorgepz
Copy link
Member

jorgepz commented Aug 24, 2022

we discuss with @TheChikenfly and @mvanzulli and decide to leave qvect as global variable by the moment

@mvanzulli
Copy link
Member Author

I think we need to add a simple problem into tests. I've been changing some files and the VIV feature is not being tested

@jorgepz
Copy link
Member

jorgepz commented Aug 30, 2022

Indeed! That is very important.

@jorgepz
Copy link
Member

jorgepz commented Jan 10, 2023

I added a subtask to improve the VIV feature considering #596

@jorgepz jorgepz added this to the v0.4.0 milestone May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants